[Webkit-unassigned] [Bug 182923] REGRESSION(r227717): Hardcoded page size causing JSC crashes on platforms with page size bigger than 16 KB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182923

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Filip Pizlo from comment #5)
> I don't think that rolling out r227717 is an option.

Yeah, we shouldn't need to. We're currently using this patch downstream:

https://src.fedoraproject.org/cgit/rpms/webkit2gtk3.git/tree/page-size.patch

So, without understanding anything about the code, this would work:

#if CPU(PPC64) || CPU(PPC64LE) || CPU(PPC) || CPU(S390) || CPU(S390X)
    static constexpr size_t blockSize = 64 * KB;
#else
    static constexpr size_t blockSize = 16 * KB;
#endif

We would need to add new WTF_CPU definitions for s390 and s390x.

It would be nicer if this were not needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180313/00a71424/attachment.html>