[Webkit-unassigned] [Bug 183386] LayoutTests/http/tests/navigation/page-cache-iframe-provisional-load.html fails with async policy delegate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 15:06:22 PDT 2018


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #335646|1                           |0
        is obsolete|                            |

--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335646
  --> https://bugs.webkit.org/attachment.cgi?id=335646
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=335646&action=review

> LayoutTests/ChangeLog:8
> +				This test relies on the happenstance that with sync poicy decision, the subframe transitions

Indentation issue. Please only use spaces, not tabs.

> LayoutTests/ChangeLog:9
> +				to FrameLoadProvisional before main frame navigation is committed.  With async delegate,

Only 1 space after the '.'

> LayoutTests/ChangeLog:15
> +        * http/tests/navigation/page-cache-iframe-provisional-load-async-delegates.html: Added.

Please update existing test too. Otherwise, it will start failing when we enable async policy delegates by default.

Also, it will help me see what has changed :)

> LayoutTests/ChangeLog:16
> +				Add a new version of the test that forces the main frame navigation to start after the

indentation issue.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180312/0db58e29/attachment.html>

More information about the webkit-unassigned mailing list