[Webkit-unassigned] [Bug 183575] Add label on github when exporting wpt tests to w3c/web-platform-test repo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 13:44:49 PDT 2018


--- Comment #3 from Brendan McLoughlin <brendan at bocoup.com> ---
Comment on attachment 335627
  --> https://bugs.webkit.org/attachment.cgi?id=335627

View in context: https://bugs.webkit.org/attachment.cgi?id=335627&action=review

>> Tools/Scripts/webkitpy/w3c/test_exporter.py:181
>>          pr_number = self._github.create_pr(self._wpt_fork_remote + ':' + self._branch_name, self._commit_message, self._commit_message + "\n" + description)
> Would create_pr always succeed, or are there some cases where it might not be successful, in which case we should add some error handling?

When testing this change locally I saw `create_pr` fail when my github token was missing the required permissions and when a pr had already been created for given bug_id. I will add some error handling for these cases.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180312/b9ddf9fe/attachment.html>

More information about the webkit-unassigned mailing list