[Webkit-unassigned] [Bug 183575] Add label on github when exporting wpt tests to w3c/web-platform-test repo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 13:37:40 PDT 2018


youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |youennf at gmail.com
 Attachment #335627|review?                     |review+
              Flags|                            |

--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335627
  --> https://bugs.webkit.org/attachment.cgi?id=335627

View in context: https://bugs.webkit.org/attachment.cgi?id=335627&action=review

> Tools/Scripts/webkitpy/w3c/common.py:42
> +WEBKIT_EXPORT_PR_LABEL = 'webkit-export'

common.py is imported from Chromium.
Ideally, we would not want to change this file so that we can easily reimport it from Chromium.
We can probably move it to test_export.py.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:181
>          pr_number = self._github.create_pr(self._wpt_fork_remote + ':' + self._branch_name, self._commit_message, self._commit_message + "\n" + description)

Would create_pr always succeed, or are there some cases where it might not be successful, in which case we should add some error handling?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180312/3d1fe41d/attachment.html>

More information about the webkit-unassigned mailing list