[Webkit-unassigned] [Bug 183028] pushState and replaceState no longer works in local file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 08:11:32 PDT 2018


--- Comment #16 from Danyao Wang <danyao at chromium.org> ---
(In reply to Brent Fulgham from comment #13)
> Comment on attachment 335473 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335473&action=review
> I think this looks correct -- I would like to see a simple test that file
> and http are not allowed to load each-other but otherwise this looks fine.

Removed unnecessary "friend" declaration. The new equalIgnoringQueryAndFragment() only uses public methods of URL so it doesn't need this friend declaration.

> > Source/WebCore/platform/URL.h:171
> > +    WEBCORE_EXPORT bool equalIgnoringQueryAndFragment(const URL&, const URL&);
> This needs to be a friend declaration. However, the bots are green, so
> perhaps we don't need this declaration at all anymore?
> > Tools/TestWebKitAPI/Tests/WebCore/URL.cpp:251
> > +        {"file:///path/to/other/file.html", "file:///path/to/file.html", false},
> Please add a failure case that compares a file URL and an HTTP URL.

Added failure cases.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180312/dde52cea/attachment.html>

More information about the webkit-unassigned mailing list