[Webkit-unassigned] [Bug 183028] pushState and replaceState no longer works in local file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183028

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335473|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #13 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 335473
  --> https://bugs.webkit.org/attachment.cgi?id=335473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335473&action=review

I think this looks correct -- I would like to see a simple test that file and http are not allowed to load each-other but otherwise this looks fine.

> Source/WebCore/platform/URL.h:171
> +    WEBCORE_EXPORT bool equalIgnoringQueryAndFragment(const URL&, const URL&);

This needs to be a friend declaration. However, the bots are green, so perhaps we don't need this declaration at all anymore?

> Tools/TestWebKitAPI/Tests/WebCore/URL.cpp:251
> +        {"file:///path/to/other/file.html", "file:///path/to/file.html", false},

Please add a failure case that compares a file URL and an HTTP URL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180310/527a60d8/attachment-0001.html>