[Webkit-unassigned] [Bug 183028] pushState and replaceState no longer works in local file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183028

--- Comment #8 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 335014
  --> https://bugs.webkit.org/attachment.cgi?id=335014
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=335014&action=review

> Source/WebCore/page/History.cpp:58
> +}

Why does that need to in the default namespace? Can you make this function static? If it's only used in one place, maybe it should be moved before History::stateObjectAdded?

> Source/WebCore/page/History.cpp:202
> +    const SecurityOrigin& documentOrigin = m_frame->document()->securityOrigin();

Are you able to use auto here?

> Source/WebCore/page/History.cpp:208
> +        && !allowSandboxException)

I would put !allowSandboxException first so that lazy evaluation of the expression is faster when allowSandboxException == true.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180307/f1d8123d/attachment.html>