[Webkit-unassigned] [Bug 156674] Build tools should work when the /usr/bin/python is python3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156674

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |annulen at yandex.ru

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Mike Gorse from comment #2)
> In some cases, it wasn't clear to me whether files needed to be opened with
> "wb", since they appear to be text, though I figured that the "b" might be
> there for a reason and left things as they were, though opening the file as
> text would allow a str to be passed to write().

Should probably take the opportunity to switch to "wb", indeed.

> Similarly, I'm guessing that there's a better way to handle jsmin.py.

I'm not a python expert. Maybe Konstantin has some opinion on this. I'm OK with uglifying the code in order to support both versions of python at the same time.

Anyway, I'll run this through the early warning service to see how the Mac and Windows bots react... it would be impressive if the first attempt doesn't break anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180307/9e5c9779/attachment-0001.html>