[Webkit-unassigned] [Bug 183286] [ARM] Assembler warnings: "use of r13 is deprecated"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183286

--- Comment #11 from Mark Lam <mark.lam at apple.com> ---
(In reply to Filip Pizlo from comment #9)
> Comment on attachment 335097 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335097&action=review
> 
> > Source/JavaScriptCore/offlineasm/arm.rb:239
> > +    operation = case m.post_match
> > +                when "eq" then "eq"
> > +                when "neq" then "neq"
> > +                when "a" then "b"
> > +                when "aeq" then "beq"
> > +                when "b" then "a"
> > +                when "beq" then "aeq"
> > +                when "gt" then "lt"
> > +                when "gteq" then "lteq"
> > +                when "lt" then "gt"
> > +                when "lteq" then "gteq"
> > +                else
> > +                    raise "unknown operation #{m.post_match}"
> > +                end
> 
> This is super weird style.
> 
> Please stick to 4 space indent.

Dominik, please do a follow up patch to fix the style issues that Fil identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180306/0a9194ac/attachment.html>