[Webkit-unassigned] [Bug 182869] [WinCairo] Add WKView and WKAPI for wincairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182869

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334997|review?                     |review-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 334997
  --> https://bugs.webkit.org/attachment.cgi?id=334997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334997&action=review

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:65
> +void WKViewSetIsInWindow(WKViewRef viewRef, bool isInWindow)
> +{
> +    notImplemented();
> +}

Let's not add unimplemented API.

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:112
> +void WKViewSetDrawsTransparentBackground(WKViewRef viewRef, bool drawsTransparentBackground)
> +{
> +}

ditto.

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:117
> +bool WKViewDrawsTransparentBackground(WKViewRef viewRef)
> +{
> +    return false;
> +}

This is also basically unimplemented.

> Source/WebKit/UIProcess/API/C/win/WKView.h:76
> +    WK_EXPORT void WKViewSetInitialFocus(WKViewRef view, bool forward);

forward is probably the wrong name here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180305/f9065c49/attachment-0001.html>