[Webkit-unassigned] [Bug 183288] offlineasm: Use temporary file for generating assembly code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 09:51:42 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=183288

--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
(In reply to Dominik Inf├╝hr from comment #4)
> Thanks for the review and the suggestion. I've updated the patch to use
> File.rename but fall back to FileUtils.cp if the rename should fail. This
> happens to be the case on my system, where /tmp is on another file system.

Hmm interesting... Your backup isn't atomic then, and you're trying to remove potentially truncated files. Maybe instead, when it fails, you should cp to a tempname in the same directory (so it'll be the same mount point), and then rename that. That would keep the actual file atomic.

WDYT?

r=me if you think that's overkill, but it should be simple.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180305/fd53d0bb/attachment-0001.html>


More information about the webkit-unassigned mailing list