[Webkit-unassigned] [Bug 183043] [WinCairo] Add WebKit Shared/win event files for wincairo webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183043

--- Comment #8 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Thank you for your review.

(In reply to Brent Fulgham from comment #5)
> Comment on attachment 334862 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334862&action=review
> > Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp:38
> > +    , m_nativeEvent()
> 
> Does this auto-initialize the various MSG members to null values? Isn't this
> uninitialized crap at this point? Or does WinAPI now have a default
> constructor that does the right thing?
At this point, I just expect that the member is just initialized but it is unnecessary.

> Then you could just do "m_nativeEvent(hwnd, message, wParam, lParam)" or
> "m_nativeEvent(createNativeEvent(hwnd, ...)"

I'll use this initialization style for NativeWeb*EventWin files.

> > Source/WebKit/Shared/win/WebEventFactory.cpp:80
> > +        || ((timeStampSeconds - gLastClickTime) * 1000.0 > ::GetDoubleClickTime());
> 
> I'd suggest using 'std::abs" here, so the code will work without casting if
> we ever build for 32-bit, or if Microsoft ever changes the definition of
> POINT.
will do.

> > Source/WebKit/Shared/win/WebEventFactory.cpp:400
> > +    static const float cScrollbarPixelsPerLine = 100.0f / 3.0f;
> 
> We should probably expose this from WebCore in some useful way, since we now
> have this hard-coded in two places.
As don said, PlatformEvent is a good place to define the value. I'll fix it.

> > Source/WebKit/Shared/win/WebEventFactory.cpp:406
> > +    WebWheelEvent::Granularity granularity  = WebWheelEvent::ScrollByPixelWheelEvent;
> 
> Looks like two spaces after granularity. I'm surprised the syntax checker
> didn't complain!

Ah, it must be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180305/1c31d326/attachment.html>