[Webkit-unassigned] [Bug 183278] Automation: stale elements not detected when removed from the DOM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183278

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #2)
> Comment on attachment 334885 [details]
> Patch
> 
> I hope we don't have 1000's of nodes or this could get expensive. It would
> be nice to just check the validity of the requested node, but I guess any
> node could be requested via script. We'd have to find the web elements after
> transforming JS payload to elements.

I started the patch by only checking the requested node indeed. But then I realized that the node can be queried multiple times, so we could be checking more than once. Then I thought, let's see what chromium does, and they also clear the cache on every execute_script call, so I decided to do the same.

> Let's just keep this version unless we think it's actually causing a
> performance problem. I like simple and brute force when we can get away with
> it.

Ok.

> r=me

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180304/061805e5/attachment.html>