[Webkit-unassigned] [Bug 183285] [GTK] Switch to use always complex text code path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183285

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #6)
> (In reply to Carlos Garcia Campos from comment #3)
> > This doesn't force simple text and it doesn't disable complex text either.
> > It either forces complex text or leaves the current auto where complex or
> > simple is used depending on the context.
> 
> Good point.
> 
> Other options:
> 
> WEBKIT_DO_NOT_FORCE_COMPLEX_TEXT=1
> WEBKIT_ALLOW_SIMPLE_TEXT=1
> 
> > > Let's not check for 0.
> > 
> > I don't see why.
> 
> It's very confusing to have an environment variable that only works when set
> to 0.

I don't thin it's confusing and it's consistent with other env vars like force AC where we also check for 0, the only difference is that in this case the default is disabled instead of enabled.

> > Most of
> > the changes that we will have to rebaseline are in text that doesn't affect
> > the test at all, like text explaining what the test does, for example. The
> > idea is to try it our during the next release cycle in the unstable
> > releases, and once we make a decision we do the rebaseline. I don't want to
> > waste the time doing a huge rebaseline to roll out the patch tomorrow.
> 
> Fair enough, as long as you're confident you won't forget to complete this
> before 2.22.

Sure.

> One more thing. The most likely reason to revert this change would be if we
> notice performance problems. But we are not actually going to notice
> performance problems, not without real perf testing. We do have a perf bot
> that I never look at, but it won't be able to test this change because the
> environment variable will be set in the test runner. How do you plan to
> evaluate the performance impact?

I'm not worried about a performance regression, it's not a problem if complex text is a bit slower. My concern is only if performance i really noticeable and affects real usage. If we think a particular website is too slow, we can try disabling the complex text force and see if there's any significant difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180304/81f3fe5a/attachment-0001.html>