[Webkit-unassigned] [Bug 183309] Create analysis task should use build time as fallback when commit time is not available.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 2 20:36:30 PST 2018


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #334946|review?                     |review+
              Flags|                            |

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334946
  --> https://bugs.webkit.org/attachment.cgi?id=334946

View in context: https://bugs.webkit.org/attachment.cgi?id=334946&action=review

> Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php:97
> +    return $result ? ($result[0]['time'] ? $result[0]['time'] : $result[0]['build_time']) : null;

Can't we just do $result[0]['time'] || $result[0]['build_time'] ?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180303/f3c20597/attachment-0001.html>

More information about the webkit-unassigned mailing list