[Webkit-unassigned] [Bug 183043] [WinCairo] Add WebKit Shared/win event files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 2 11:15:59 PST 2018


--- Comment #6 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 334862
  --> https://bugs.webkit.org/attachment.cgi?id=334862

View in context: https://bugs.webkit.org/attachment.cgi?id=334862&action=review

>> Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp:43
>> +    m_nativeEvent.lParam = lParam;
> What about 'time' and 'pt'? Aren't those uninitialized now? Maybe we never use them, but it's still a potential problem if we have code that inspects that data.
> This might be cleaner if we had some kind of WebKit 'MSG' initializer function, since you repeat this in a few places.
> Then you could just do "m_nativeEvent(hwnd, message, wParam, lParam)" or "m_nativeEvent(createNativeEvent(hwnd, ...)"

There's actually something like that hanging out in Tools/DumpRenderTree/win/EventSender.cpp.

We could add something into WebEventFactory that would create the MSG.

>> Source/WebKit/Shared/win/WebEventFactory.cpp:400
>> +    static const float cScrollbarPixelsPerLine = 100.0f / 3.0f;
> We should probably expose this from WebCore in some useful way, since we now have this hard-coded in two places.

I started poking around a bit more and this code is present Source/WebCore/platform/win/WheelEventWin.cpp as well as Tools/DumpRenderTree/win/EventSender.cpp.

Is there any reason the WebEvent things aren't using PlatformEvents? I see GTK bolts some stuff onto PlatformKeyboardEvent specifically for WebKit(2) use. I'm just wondering if we should maybe open a bug to refactor the PlatformEvents into something usable within WebKit.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180302/312e3ed4/attachment.html>

More information about the webkit-unassigned mailing list