[Webkit-unassigned] [Bug 183288] offlineasm: Use temporary file for generating assembly code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183288

JF Bastien <jfbastien at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334897|review?                     |review+
              Flags|                            |

--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 334897
  --> https://bugs.webkit.org/attachment.cgi?id=334897
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334897&action=review

One suggestion, otherwise r=me

> Source/JavaScriptCore/offlineasm/asm.rb:398
> +FileUtils.cp(tempFile, outputFlnm)

I think you want rename, not copy:
  http://ruby-doc.org/core-2.1.1/File.html#method-c-rename

If it follows UNIX convention then it'll be atomic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180302/a820bcc5/attachment.html>