[Webkit-unassigned] [Bug 183043] [WinCairo] Add WebKit Shared/win event files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 14:40:43 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=183043

Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |don.olmstead at sony.com

--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 334511
  --> https://bugs.webkit.org/attachment.cgi?id=334511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334511&action=review

This should be fine its just WPE and iOS are not compiling due to the #else being removed.

> Source/WebKit/Shared/NativeWebKeyboardEvent.h:90
> -#else
> -    const void* nativeEvent() const { return nullptr; }
> +#elif PLATFORM(WIN)
> +    const MSG* nativeEvent() const { return &m_nativeEvent; }
>  #endif

WPE and ios are failing because the #else was removed

> Source/WebKit/Shared/NativeWebMouseEvent.h:71
>      const GdkEvent* nativeEvent() const { return m_nativeEvent.get(); }
> -#else
> -    const void* nativeEvent() const { return nullptr; }
> +#elif PLATFORM(WIN)
> +    const MSG* nativeEvent() const { return &m_nativeEvent; }
>  #endif

Same problem here

> Source/WebKit/Shared/NativeWebWheelEvent.h:71
> -#else
> -    const void* nativeEvent() const { return nullptr; }
> +#elif PLATFORM(WIN)
> +    const MSG* nativeEvent() const { return &m_nativeEvent; }
>  #endif

Same problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180301/40cd525d/attachment.html>


More information about the webkit-unassigned mailing list