[Webkit-unassigned] [Bug 183155] [FreeType] Color emojis in WebKitGTK+ for great justice

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 12:02:34 PST 2018


--- Comment #19 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #18)
> (In reply to Michael Catanzaro from comment #17)
> > I would use a non-ref test, because a reftest would be difficult. And I
> > would use an image for the expected results rather than the render tree.
> > That way it will be obvious enough if the emoji is no longer there.
> We don't have pixels tests enabled. 

Ah, yes, good point... the pixel tests are basically useless, then.

> And the thing is that this is not
> reproducible in the test env because of our custom fontconfig configuration.

That's not a problem, because we control the configuration. It's kind of expected that it will have to be updated when adding new font tests. But I think the only sane way to do this would be as a pixel test, and there's no value in adding pixel tests, so I wouldn't worry about it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180301/ff790c1f/attachment.html>

More information about the webkit-unassigned mailing list