[Webkit-unassigned] [Bug 187183] [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187183

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 343954
  --> https://bugs.webkit.org/attachment.cgi?id=343954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343954&action=review

> Tools/WebKitTestRunner/TestOptions.h:75
>      bool hasSameInitializationOptions(const TestOptions& options) const

This will definitely work, but I think it's a bit confusing to have a helper named "hasSameInitializationOptions" if it may return false for two identical TestOptions that both have the runSingly flag.

I think this would be a bit less misleading if we:
- Check that options.runSingly matches in hasSameInitializationOptions
- And also return `!options.runSingly && m_options.hasSameInitializationOptions(options)` from the call site in viewSupportsOptions

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180629/b769f659/attachment.html>