[Webkit-unassigned] [Bug 187187] New: REGRESSION(r233362): check_flatpak() should not be verbose when flatpak environment has not been initialized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187187

            Bug ID: 187187
           Summary: REGRESSION(r233362): check_flatpak() should not be
                    verbose when flatpak environment has not been
                    initialized
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, tsaunier at gnome.org
            Blocks: 186771

It happens that when the flatpak environment has not been initialized, the scripts still try to run the flatpak binary in the function check_flatpak() in flatpakutils.py


For example, If i just uninstall flatpak and I try to run I get

$ Tools/Scripts/run-webkit-tests --gtk --release

You need to install flatpak >= 0.10.0 to be able to use the 'Tools/Scripts/run-webkit-tests' script.

You can find some informations about how to install it for your distribution at:
    * http://flatpak.org/

20:15:13.186 21463 Using port 'gtk-wk2'
[...]

Or on the bots, just check the ouput generate-jsc-bundle from the release bot, the noise about flatpak there:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/13303/steps/generate-jsc-bundle/logs/stdio


I think this should be avoided. 

The function check_flatpak() should avoid doing any check (or print any warning) if the flatpak environment has not been initialized


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=186771
[Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180629/e017f89c/attachment.html>