[Webkit-unassigned] [Bug 187167] [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187167

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Hironori.Fujii at sony.com

--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 343887
  --> https://bugs.webkit.org/attachment.cgi?id=343887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343887&action=review

I'm not a reviewer. This is an informal review.

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:48
> +std::vector<char> toUtf8(const wchar_t* src, size_t srcLength)

Why do you want to use std::vector<char> for utf-8 strings?

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:233
> +    SetWindowText(thisWindow.m_urlBarWnd, urlString.data());

Why did you replace c_str with data? Windows API expects a null-terminated string.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180629/83f6fbe7/attachment.html>