[Webkit-unassigned] [Bug 187139] [Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187139

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Frédéric Wang (:fredw) from comment #2)
> (In reply to Carlos Garcia Campos from comment #0)
> > This is yet another crash in animations code due to nullopt value being used
> > without check. This is very easy to reproduce for me just visiting
> > gitlab.gnome.org. The workaround as usual is easy:
> > 
> > -    auto timeOffset = animation()->currentTime().value().seconds();
> > +    auto timeOffset = animation()->currentTime().value_or(0_s).seconds();
> > 
> > but I guess that's not the right fix.
> 
> FWIW, !animation()->currentTime() also happens on macOS except that the
> program does not crash and seems to continue with a dummy value. Maybe
> that's because clang does not implement std::optional the correct way.
> 
> I wonder whether the function should instead just exist if the time value is
> unresolved?

See https://bugs.webkit.org/show_bug.cgi?id=186536

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180628/528d243c/attachment.html>