[Webkit-unassigned] [Bug 187133] Switch OS(FUCHSIA) to using JSCOnly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187133

--- Comment #5 from Adam Barth <abarth at webkit.org> ---
> OK, then, I think we should remove Fuchsia related things in webkitdir.pm.
> We can pass cmakeargs by using `--cmakeargs`.
> So basically, `Tools/Scripts/build-jsc --jsc-only
> --cmakeargs="-DCMAKE_TOOLCHAIN_FILE=XXX"` should work.

Neat!

> If we use JSCOnly port in Fuchsia OS, I think we do not need to check
> Fuchsia related things in webkitdirs.pm. We can just use `--jsc-only`, and
> we can remove Fuchsia related things in webkitdirs.pm.

Yes, that seems to work.  Done.

> Why not passing it with `cmakeargs`? `Tools/Scripts/build-jsc
> --cmakeargs="-DCMAKE_TOOLCHAIN_FILE=XXX"`

Good idea.

> Minor: ‘ (single quote) => “ (double quote)

Removed.

> Although unwritten, we prefer double-quoted string literals over single
> quoted ones unless we explicitly do not want string interpolation or using
> single quotes reduces the need to escape characters in the string.

Got it.  I've removed this code, in any case.

> > Tools/Scripts/webkitdirs.pm:2211
> > +        push @args, "-DCMAKE_TOOLCHAIN_FILE=$toolchainFile";
> 
> This will not work correctly if the path has spaces in its name. We should
> take a similar approach as done for -DCMAKE_INSTALL_PREFIX and surround
> $toolchainFile in quotes. Is there a better way to write this code to handle
> a path that has embedded space characters?

Apparently the best way to write this code is to delete it.  :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180628/e3fbfe57/attachment.html>