[Webkit-unassigned] [Bug 187133] Switch OS(FUCHSIA) to using JSCOnly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187133

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 343792
  --> https://bugs.webkit.org/attachment.cgi?id=343792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343792&action=review
> Tools/Scripts/webkitdirs.pm:2209
> +    my $toolchainFile = $ENV{'CMAKE_TOOLCHAIN_FILE'};

Minor: ‘ (single quote) => “ (double quote)

Although unwritten, we prefer double-quoted string literals over single quoted ones unless we explicitly do not want string interpolation or using single quotes reduces the need to escape characters in the string.

> Tools/Scripts/webkitdirs.pm:2211
> +        push @args, "-DCMAKE_TOOLCHAIN_FILE=$toolchainFile";

This will not work correctly if the path has spaces in its name. We should take a similar approach as done for -DCMAKE_INSTALL_PREFIX and surround $toolchainFile in quotes. Is there a better way to write this code to handle a path that has embedded space characters?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180628/a71786b7/attachment.html>