[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #82 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
(In reply to Michael Catanzaro from comment #78)
> Please also still use NeverDestroyed, though. It should be
> NeverDestroyed<GtkStyleContext> with no GRefPtr involved. (It was dumb of me
> to suggest that.) See bug #186969 for a bunch of examples of how to do this.
> This will ensure we avoid leak warnings from asan.

OK. done

(In reply to Michael Catanzaro from comment #75)
> Comment on attachment 343018 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343018&action=review
> 
> > Source/WebCore/platform/gtk/RenderThemeGadget.cpp:28
> >  #include "RenderThemeGadget.h"
> > +#include <mutex>
> 
> There should be a blank line before including <mutex>. I'm surprised the
> style bot didn't complain.

OK. done


(In reply to Michael Catanzaro from comment #77)
> Please try refactoring it, yes.

I'll try to land a solution for bug 175067 first before landing here to avoid having to refactor code that will be removed anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180626/6bce62f5/attachment-0001.html>