[Webkit-unassigned] [Bug 187044] New: animations/transition-and-animation-1.html is failing since r233164

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187044

            Bug ID: 187044
           Summary: animations/transition-and-animation-1.html is failing
                    since r233164
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cturner at igalia.com
                CC: bugs-noreply at webkitgtk.org

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/animations/transition-and-animation-1-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/animations/transition-and-animation-1-actual.txt
@@ -1,3 +1,3 @@
 This test has a transition and animation on the same property (-webkit-transform). But the transition is never triggered, so nothing should be moving when the animation finishes.
-PASS - "webkitTransform" property for "box" element at 0.55s saw something close to: none
+FAIL - "webkitTransform" property for "box" element at 0.55s expected: none but saw: matrix(1, 0, 0, 1, 200.1999969482422, 0)


The stderr is more interesting,

failed to create drawable


This was caused by r233164 from bug 186981,

diff --git a/Source/WebCore/animation/KeyframeEffectReadOnly.cpp b/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
index 96396956a9d..caf57bcd202 100644
--- a/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
+++ b/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
@@ -1164,6 +1164,9 @@ void KeyframeEffectReadOnly::updateAcceleratedAnimationState()
     if (!m_shouldRunAccelerated)
         return;

+    if (!renderer())
+        return;
+
     auto localTime = animation()->currentTime();

     // If we don't have a localTime or localTime < 0, we either don't have a start time or we're before the startTime

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180626/cac67c8c/attachment-0001.html>