[Webkit-unassigned] [Bug 186997] [Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 13:35:47 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186997

--- Comment #10 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to David Kilzer (:ddkilzer) from comment #9)
> (In reply to David Kilzer (:ddkilzer) from comment #8)
> > (In reply to Ross Kirsling from comment #7)
> > > Looks like DocumentAnimationScheduler really is an undefined type on Windows:
> > > -
> > > https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Platform.h#L1138-
> > > L1140
> > > -
> > > https://github.com/WebKit/webkit/blob/master/Source/WebCore/animation/
> > > DocumentAnimationScheduler.h#L28
> > > 
> > > So I think r233144 could be reversed in favor of three extra #ifs in
> > > Document.cpp (unless we wanted to make a stub implementation).
> > 
> > Thanks!  Just landed:
> > 
> > Committed r233163: <https://trac.webkit.org/changeset/233163>
> 
> And:
> 
> Committed r233170: < https://trac.webkit.org/changeset/233170>

You beat me to the punch. :)
Apparently KeyframeEffectReadOnly.cpp had a legitimate separate issue, but builds should go green after this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180625/fbd7a0ad/attachment.html>


More information about the webkit-unassigned mailing list