[Webkit-unassigned] [Bug 186956] AX: [iOS] VoiceOver scroll position is jumpy in frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186956

--- Comment #3 from Nan Wang <n_wang at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 343409 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343409&action=review
> 
> > Source/WebCore/platform/ScrollView.cpp:851
> > +    if (delegatesScrolling())
> > +        return convertToContainingView(contentsToView(rect));
> 
> This looks like it's duplicating what Frederic was trying to do in bug
> 182785. You need to be careful here; this change can affect both UIWebView
> and WKWebView on iOS, and you need to examine the callers to make sure you
> didn't break anything. Also bear in mind that we don't have good
> UIWebViewtest coverage.

I think that's a different issue since it's checking the window? 
contentsToContainingViewContents() is only being called in RenderLayer::scrollRectToVisible()

Do you mean I should check all the callers of RenderLayer::scrollRectToVisible()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180625/fd89cb78/attachment.html>