[Webkit-unassigned] [Bug 186678] [GStreamer] Some media stream tests are crashing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 04:22:00 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186678

--- Comment #17 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 343328
  --> https://bugs.webkit.org/attachment.cgi?id=343328
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=343328&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:755
> +    GstStream* stream = nullptr;
> +
> +    if (!m_isLegacyPlaybin) {
> +        gst_stream_collection_get_stream(m_streamCollection.get(), index);
> +        if (!stream) {
> +            GST_WARNING_OBJECT(pipeline(), "No stream to select at index %u", index);
> +            return;
> +        }

Was this actually tested? :)
I've just noticed now that stream is never set :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180625/988a54e3/attachment.html>


More information about the webkit-unassigned mailing list