[Webkit-unassigned] [Bug 182272] SUPPRESS_ASAN should be implemented for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182272

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Security-Sensitive          |
          Component|Security                    |Web Template Framework
           Assignee|webkit-security-unassigned@ |webkit-unassigned at lists.web
                   |lists.webkit.org            |kit.org
            Product|Security                    |WebKit
            Summary|Possible stack buffer       |SUPPRESS_ASAN should be
                   |overflow in                 |implemented for GCC
                   |JSC::ConservativeRoots::gen |
                   |ericAddSpan                 |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
This function is annotated with SUPPRESS_ASAN, which is implemented in Compiler.h:

#define ASAN_ENABLED COMPILER_HAS_CLANG_FEATURE(address_sanitizer)

#if ASAN_ENABLED
#define SUPPRESS_ASAN __attribute__((no_sanitize_address))
#else
#define SUPPRESS_ASAN
#endif

GCC supports __attribute__((no_sanitize_address)) but it does not support __has_feature() (so COMPILER_HAS_CLANG_FEATURE does not work). We probably just need to ensure SUPPRESS_ASAN gets defined somehow.

Suggestion:

#define ASAN_ENABLED COMPILER_HAS_CLANG_FEATURE(address_sanitizer) || COMPILER(GCC)

That should be fine since we have other checks to stop the build before it gets to this point if GCC is old.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180622/d2915296/attachment-0001.html>