[Webkit-unassigned] [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 09:42:11 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186771

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343279|0                           |1
        is obsolete|                            |
 Attachment #343279|review?, commit-queue?      |
              Flags|                            |
 Attachment #343333|                            |review?, commit-queue?
              Flags|                            |

--- Comment #27 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343333

  --> https://bugs.webkit.org/attachment.cgi?id=343333&action=review

Patch

(In reply to Carlos Alberto Lopez Perez from comment #26)
> More minor issues:
> 
> ====================================================================
>  WebKit is now built (00m:01s). 
>  To run MiniBrowser with this newly-built code, use the
>  "../../../../app/webkit/Tools/Scripts/run-minibrowser" script.
> ====================================================================
> 
> 
> That message should be fixed somehow, as the script name is just
> "Tools/Scripts/run-minibrowser"

Made sure we just print "Tools/Scripts/run-minibrowser" when running inside flatpak, we can't
really figure out the host path in there. 

I also fixed wrong check that was leading to updating flatpak when calling webkit-build.

+ Minor cleanup to check wheather `webkit-build` should be run inside flatpak.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180622/b0d1d4a3/attachment-0001.html>


More information about the webkit-unassigned mailing list