[Webkit-unassigned] [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186771

--- Comment #23 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 343279
  --> https://bugs.webkit.org/attachment.cgi?id=343279
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=343279&action=review

I'm testing it and I have this comment so far:

Each time you run build-webkit (or re-run update-webkitgtk-flatpak) it tries to update the flatpak environment, even when this has been already completed and the flatpak definition has not changed.

That is a process that is taking in my tests around 30-60 seconds even when there are no updates.
So this makes incremental builds kind of inconvenient.

Also its a process that seems to be dependent of networking available.. does that mean that I can't re-build webkit without an internet connection when I have already built the flatpak previously? that's bad.

So I think we should do something like we do with JHBuild, that is:

 - 1. When the JHBuild environment is (correctly) initialized we store a md5 hash of the input files to JHBuild (the moduleset). Check script update-webkit-libs-jhbuild
 - 2. The next time the JHBuild scripts are executed, first thing they do is to check if the input files have changed compared to that md5 hash
 - 3. If the input files have not changed, then they skip trigerring any update of the third-party/jhbuild directory


That allows it to trigger updates when needed (someone modified the moduleset), but avoids doing unneeded work otherwise.


Do you think something like that would be also possible for update-webkitgtk-flatpak?

> Tools/flatpak/flatpakutils.py:532
> +            version = output.decode("utf-8").split(" ")[1].strip("\n")
> +            if comparable_version(version) < comparable_version(required_version):
> +                Console.message("\n%s%s %s required but %s found."
> +                                " Please update and try again%s\n", Colors.FAIL,
> +                                app, version, version, Colors.ENDC)

This should be:
-                                app, version, version, Colors.ENDC)
+                                app, required_version, version, Colors.ENDC)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180622/8fbd9147/attachment.html>