[Webkit-unassigned] [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186771

--- Comment #21 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 343238
  --> https://bugs.webkit.org/attachment.cgi?id=343238
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=343238&action=review

> Tools/Scripts/run-gtk-tests:134
> +    flatpakutils.run_in_sandbox_if_available(sys.argv)
> +    if not flatpakutils.is_sandboxed() and not jhbuildutils.enter_jhbuild_environment_if_available("gtk"):
> +        print '***'
> +        print '*** Warning: jhbuild environment not present and not running in flatpak.'
> +        print '*** Run update-webkitgtk-libs before build-webkit or directly build-webkit --flatpak to ensure proper testing.'
> +        print '***'

This message now should reflect the last update.

- print '*** Run update-webkitgtk-libs before build-webkit or directly build-webkit --flatpak to ensure proper testing.'
+ print '*** Run update-webkitgtk-libs or update-webkitgtk-flatpak before build-webkit to ensure proper testing.'

> Tools/Scripts/run-webdriver-tests:82
> +        if not jhbuildutils.enter_jhbuild_environment_if_available(port.name()):
> +            print '***'
> +            print '*** Warning: jhbuild environment not present and not running in flatpak.'
> +            print '*** Run update-webkitgtk-libs before build-webkit or directly build-webkit --flatpak to ensure proper testing.'
> +            print '***'

ditto

> Tools/Scripts/run-wpe-tests:56
> +    if not flatpakutils.is_sandboxed() and not jhbuildutils.enter_jhbuild_environment_if_available("wpe"):
> +        print '***'
> +        print '*** Warning: jhbuild environment not present and not running in flatpak.'
> +        print '*** Run update-webkitgtk-libs before build-webkit or directly build-webkit --flatpak to ensure proper testing.'
> +        print '***'

ditto

> Tools/Scripts/update-webkitgtk-libs:-18
> -

This line deletion is not needed

> Tools/Scripts/update-webkitwpe-libs:-18
> -

ditto

> Tools/flatpak/org.webkit.GTK.yaml:62
> +- name: xvfb
> +  sources:
> +    - type: git
> +      url: https://anongit.freedesktop.org/git/xorg/xserver.git
> +      branch: xorg-server-1.19.6
> +    - type: patch
> +      path: patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch

I think the patch xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch should be preserved here.
That one is needed for making xvfb load the dri driver (swrast_dri.so) from the software-only mesa built at /app/softGL instead of the default's one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180621/cd590988/attachment-0001.html>