[Webkit-unassigned] [Bug 186870] New: NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186870

            Bug ID: 186870
           Summary: NSURLAuthenticationMethodOAuth challenges are surfaced
                    to clients in -didReceiveAuthenticationChallenge as
                    NSURLAuthenticationMethodDefault
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit API
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ansh_shukla at apple.com

When WebKit receives an authentication request header of the form: WWW-Authenticate     OAuth realm="https%3A%2F%2Fauthenticate.apple.com", it converts it to an internal representation of type ProtectionSpaceAuthenticationSchemeUnknown. However, when this authentication challenge is eventually sent to clients with -didReceiveAuthenticationChallenge, its cocoa representation has authentication type default because the implementation of nsSpace() doesn't handle the unknown case:

    default:
        break;
        ASSERT_NOT_REACHED();
    }

    m_nsSpace = adoptNS(proxyType
        ? [[NSURLProtectionSpace alloc] initWithProxyHost:host() port:port() type:proxyType realm:realm() authenticationMethod:method]
        : [[NSURLProtectionSpace alloc] initWithHost:host() port:port() protocol:protocol realm:realm() authenticationMethod:method]);


Passing in nil to the NSURLProtectionSpace initializer will give it type default.

To clients, this manifests as an authentication challenge of type HTTP basic auth, since the protocol will be HTTP.

In the WK2 C++ API, there was a custom object which did have the enum type: kWKProtectionSpaceAuthenticationSchemeUnknown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180621/0a0b4c5f/attachment-0001.html>