[Webkit-unassigned] [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 17:58:48 PDT 2018


--- Comment #17 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Thibault Saunier from comment #16)
> Created attachment 343195 [details]
> Patch.
> (In reply to Carlos Alberto Lopez Perez from comment #15)
> > Comment on attachment 343191 [details]
> > Patch.
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=343191&action=review
> > 
> > > Tools/ChangeLog:14
> > > +        The workflow is very similar to the "jhbuild based" on except that when running `build-webkit` you need to pass
> > > +        the `--flatpak` argument, afterward, other script will detect that a flatpak based environment
> > > +        has been setup and will be used.
> > 
> > Can we have a way of enabling flatpak environment that can be called before
> > "build-webkit" and can we make the "build-webkit" script smart enough to
> > detect that this previous step has been called and do the expected thing?
> > 
> > The bots run a "jhbuild" step before the step "build-webkit". But the step
> > "build-webkit" doesn't receive any special parameter. It simply auto-detects
> > the JHBuild dir and enables it if its there.
> > 
> > 
> > So the idea is to replace the step "jhbuild" with a step "flatpak", but
> > without having to pass any extra parameter to the step/script "build-webkit".
> You can now do `mkdir -p WebKitBuild/GTK/FlatpakTreeRelease && build-webkit
> --release --gtk` or
> `mkdir -p WebKitBuild/WPE/FlatpakTreeRelease && build-webkit --debug --wpe`
> Is that enough?

Its enough if that is done as part of the script that creates the initial environment for flatpak

Working with the new flatpak environment instead of jhbuild should require no extra or different arguments to any of the scripts, but the one to intialize&build third-party.

* With jhbuild we build third-party as follows:

  $ Tools/Scripts/update-webkitgtk-libs

And then we run all the other scripts (build-webkit, run-tests, etc) without passing any extra arguments. That scripts are smart enough to detect the JHBuild third-party dir has been initialized and they use it.

* So, for the new flatpak environment we need something like:

  $ Tools/Scripts/update-webkitgtk-flatpak (or any other name you wish)

And then all the scripts should detect that has been initialized and proceed to use flatpak

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180621/d9145c62/attachment.html>

More information about the webkit-unassigned mailing list