[Webkit-unassigned] [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186771

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Carlos Alberto Lopez Perez from comment #6)
> I think we should make the usage of this as transparent of possible, so if
> possible the way of building-webkit and running tests should remain
> unchanged.
> The rationale is:
> 1. Avoid users having to learn about a new way of running tests or building
> webkit.
> 2. Avoid having to modify all the buildbot configs to pass new arguments.
> 
> Currently, the JHBuild tooling automatically runs everything under the
> JHBuild environment if possible (no need to pass any special argument to the
> script run-webkit-tests, etc). It does so by simply checking the existence
> of the directory WebKitBuild/Dependencies${PORT} and if that directory
> exists it just enters into the jhbuild environment before running any test
> or building anything. Check the function
> enter_jhbuild_environment_if_available() that its automatically called from
> the layout test scripts, run perf test scripts as well as from the API test
> scripts.
> 
> 
> So I think this will work better if the arguments and command needed to
> build webkit and run the test steps remain unchanged.
> The scripts doing this should somehow check if the flatpak environment has
> been initialized and then try to use it automatically, otherwise continue
> with current behaviour (try to use jhbuild)

I was expecting a comment like that one and I understand the reasoning. While it
would be simple to keep the current behaviour I didn't do it this mostly because
of personal test and habits, I have not problem adding the jhbuild behaviour back
if you think it is worth it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180618/b2a25ddf/attachment.html>