[Webkit-unassigned] [Bug 186697] AX: [macOS] When zoom is enabled, focus doesn't follow text cursor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 11:20:39 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186697

--- Comment #3 from Nan Wang <n_wang at apple.com> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 342849 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342849&action=review
> 
> > Source/WebCore/editing/mac/FrameSelectionMac.mm:42
> > +    CGFloat screenHeight = screenRectForPrimaryScreen().height();
> > +    if (screenHeight > 0)
> >          bounds.origin.y = (screenHeight - (bounds.origin.y + bounds.size.height));
> > -    } else
> > +    else
> >          bounds = CGRectZero;    
> 
> Might be even better to use the toUserSpaceForPrimaryScreen function instead
> of calling screenRectForPrimaryScreen directly.

Great thanks! I'll update that

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180618/ab4d6d4d/attachment.html>


More information about the webkit-unassigned mailing list