[Webkit-unassigned] [Bug 182923] REGRESSION(r227717): Hardcoded page size causing JSC crashes on platforms with page size bigger than 16 KB

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 16 10:11:57 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=182923

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
After chatting with Caitlin about this, and based on Filip's comments that the block size must be a compile-time constant and not computed from page size, I propose we just take the simple Fedora patch:

(In reply to Michael Catanzaro from comment #6)
> #if CPU(PPC64) || CPU(PPC64LE) || CPU(PPC) || CPU(UNKNOWN)
>     static constexpr size_t blockSize = 64 * KB;
> #else
>     static constexpr size_t blockSize = 16 * KB;
> #endif

We can also define it at the CMake level and allow overriding it, but that makes cross-compiling more difficult and does not seem useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180616/0b965394/attachment.html>


More information about the webkit-unassigned mailing list