[Webkit-unassigned] [Bug 186709] SimpleLineLayout::FlowContents wastes 54KB of Vector capacity on nytimes.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186709

--- Comment #2 from zalan <zalan at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #0)
> Tooling from bug 186698:
> 
> Wasted capacity: 54096 bytes (used 7728 of 61824 bytes, utilization: 12.50%)
> - 161 allocations
> 1   0x108927092
> WTF::VectorBuffer<WebCore::SimpleLineLayout::FlowContents::Segment,
> 8ul>::VectorBuffer(unsigned long, unsigned long)
> 2   0x108926fa8
> WTF::Vector<WebCore::SimpleLineLayout::FlowContents::Segment, 8ul,
> WTF::CrashOnOverflow, 16ul>::Vector<0ul, WTF::CrashOnOverflow,
> 16ul>(WTF::Vector<WebCore::SimpleLineLayout::FlowContents::Segment, 0ul,
> WTF::CrashOnOverflow, 16ul> const&)
> 3   0x1088faaed
> WTF::Vector<WebCore::SimpleLineLayout::FlowContents::Segment, 8ul,
> WTF::CrashOnOverflow, 16ul>::Vector<0ul, WTF::CrashOnOverflow,
> 16ul>(WTF::Vector<WebCore::SimpleLineLayout::FlowContents::Segment, 0ul,
> WTF::CrashOnOverflow, 16ul> const&)
> 4   0x1088fa790
> WebCore::SimpleLineLayout::FlowContents::FlowContents(WebCore::
> RenderBlockFlow const&)
> 5   0x1088fab3d
> WebCore::SimpleLineLayout::FlowContents::FlowContents(WebCore::
> RenderBlockFlow const&)
> 6   0x10892f8a6
> WebCore::SimpleLineLayout::RunResolver::RunResolver(WebCore::RenderBlockFlow
> const&, WebCore::SimpleLineLayout::Layout const&)
> 7   0x10892f9c5
> WebCore::SimpleLineLayout::RunResolver::RunResolver(WebCore::RenderBlockFlow
> const&, WebCore::SimpleLineLayout::Layout const&)
> 8   0x1088f8309 WebCore::SimpleLineLayout::Layout::runResolver() const

In initializeSegments(), we call segments.reserveCapacity(numberOfChildren); on the vector -and we recreate it every time the content changes. Is there stacktraces for the wasted allocations?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180616/e91ddef2/attachment.html>