[Webkit-unassigned] [Bug 186566] Semantic colors should not be transformed by color-filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186566

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342811|review?                     |review+
              Flags|                            |

--- Comment #18 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 342811
  --> https://bugs.webkit.org/attachment.cgi?id=342811
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342811&action=review

> Source/WebCore/rendering/RenderTreeAsText.cpp:245
> -            if (o.parent()->style().visitedDependentColor(CSSPropertyColor) != color)
> +            if (o.parent()->style().visitedDependentColor(CSSPropertyColor).rgb() != color.rgb())

Really confusing that "rgb()" includes alpha. It looks like these comparisons are ignoring alpha.

Maybe add an explicit bool Color::rgbaEquals(const Color&) or something.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180615/b1361beb/attachment.html>