[Webkit-unassigned] [Bug 186531] [Datalist][macOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186531

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 342477
  --> https://bugs.webkit.org/attachment.cgi?id=342477
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342477&action=review

> Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:226
> +- (BOOL)acceptsFirstResponder {

{ on the next line

> Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:387
> +    NSRect windowRect = [[_view window] convertRectToScreen:[_view convertRect:NSMakeRect(rect.x(), rect.y(), rect.width(), rect.height()) toView:nil]];

You should just be able to cast from IntRect->NSRect, no?

> Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:417
> +    WKDataListSuggestionCell *result = [tableView makeViewWithIdentifier:@"WKDataListSuggestionCell" owner:self];

I think we usually keep cell reuse identifiers statically (see Wenson’s recent watch form controls patches)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180613/0cc10cf6/attachment.html>