[Webkit-unassigned] [Bug 186547] [WPE] Build getUserMedia support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 00:26:41 PDT 2018


Alejandro G. Castro <alex at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #342575|review?                     |review+
              Flags|                            |

--- Comment #12 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 342575
  --> https://bugs.webkit.org/attachment.cgi?id=342575
Added alsa devel as required dependency in the install-dependencies script

View in context: https://bugs.webkit.org/attachment.cgi?id=342575&action=review

LGTM, let's try it, I added a couple of minor modifications.

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:217
> +    copy = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,

Can we do auto copy = ... here?

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:221
> +    cr = cairo_create(copy.get());

I think we can do: auto cr = adoptRef(cairo_create(copy.get())); And remove the destroy of the cr later.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180613/e604a556/attachment.html>

More information about the webkit-unassigned mailing list