[Webkit-unassigned] [Bug 186560] [GTK][WPE] WebDriver: handle acceptInsecureCertificates capability

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 16:10:44 PDT 2018


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
 Attachment #342527|review?                     |review-
              Flags|                            |

--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 342527
  --> https://bugs.webkit.org/attachment.cgi?id=342527

View in context: https://bugs.webkit.org/attachment.cgi?id=342527&action=review

Everything else looks fine except the issue noted.

> Source/WebDriver/ChangeLog:9
> +        cabaility is sent.

Nit: capability

> Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:89
> +    dispatch_async(dispatch_get_main_queue(), ^{

r- because this causes a UAF (which I only caught by applying manually and running tests ;-)). You need to do the following outside the block:

NSString *requestedSessionIdentifier = sessionIdentifier;

then use that NSString as the argument rather than applying the type conversion inside the block. The WTFString may no longer be around at that time.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180612/a5d6c6c2/attachment-0001.html>

More information about the webkit-unassigned mailing list