[Webkit-unassigned] [Bug 186189] Crash in WebAnimation::runPendingPlayTask

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186189

--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 341746
  --> https://bugs.webkit.org/attachment.cgi?id=341746
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341746&action=review

I assume that this fixes several animation tests? I would mention that in the changelog.

> Source/WebCore/animation/WebAnimation.cpp:831
>      // 3. If animation's start time is unresolved, perform the following steps:
>      if (!m_startTime) {

Maybe you could avoid the layout test timeout by doing the check here instead?

if (!m_startTime && readyTime)

That way, the behavior should only be changed in the case where the code is going to imminently dereference readyTime when it is nullopt: m_readyPromise will still be resolved, and updateFinishedState will be called. I'm not sure if that's the most-correct solution, but the current code is definitely wrong, and it seems likely to avoid breaking the test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180612/fcc3e137/attachment.html>