[Webkit-unassigned] [Bug 186359] Add script to update web-platform-tests expectations after import

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186359

--- Comment #10 from Brendan McLoughlin <brendan at bocoup.com> ---
Comment on attachment 342430
  --> https://bugs.webkit.org/attachment.cgi?id=342430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342430&action=review

>> Tools/Scripts/webkitpy/w3c/test_updater.py:355
>> +            results['name'] = file_name
> 
> Maybe _flatten_path could do the update here so that _pre_process_tests will be simpler.
> I am not sure _flatten_path is the right method name.
> Maybe something like _compute_test_list would be better?

I looked into this change and I think I want to leave it as is. ` _flatten_path` converts a deeply nested dict that looks like this: 
{"imported":{"w3c":{"web-platform-tests":{"xhr":{"responsexml-document-properties.htm":{"expected":"PASS","actual":"TEXT"}}}}}}

into a shallower dict where the key is the full test path like this:
{"imported/w3c/web-platform-tests/responsexml-document-properties.htm":{"expected":"PASS","actual":"TEXT"}}

Do to how it recursively calls itself to build the outer key, trying to add the name to the inner dict makes it more complicated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180611/18ae3205/attachment-0001.html>