[Webkit-unassigned] [Bug 186531] [Datalist][macOS] Add suggestions UI for TextFieldInputTypes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 12:25:01 PDT 2018


--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 342452
  --> https://bugs.webkit.org/attachment.cgi?id=342452

View in context: https://bugs.webkit.org/attachment.cgi?id=342452&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6433
>> +        if ([childWindow isKindOfClass:NSClassFromString(@"WKDataListSuggestionWindow")])
> This whole thing is not great. If this is really how you want to implement it, maybe hide its ugliness away in the test runners? Maybe Wenson has some thoughts.

Yeah, I think we can do this in two ways:

1. If we want to try and inspect the window hierarchy to find the datalist suggestion window, let's just put that logic in the test runner as Tim suggested instead of as SPI in WKWebView (since the implementation of this wouldn't require any special knowledge internal to WebKit or WKWebView).

2. We can also add a bit of plumbing from WKWebView to WebPageProxy, and ask it for the existence of m_dataListSuggestionsDropdown, so we don't need to do the NSWindow crawl.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180611/d6bf445a/attachment.html>

More information about the webkit-unassigned mailing list