[Webkit-unassigned] [Bug 186471] MediaTrackCapabilities.deviceId and groupId are not hashed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186471

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342412|review?                     |review+
              Flags|                            |

--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 342412
  --> https://bugs.webkit.org/attachment.cgi?id=342412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342412&action=review

Thank you for the fix!

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:47
> +                if(trackKind !== 'audio' && trackKind !== 'video')

Nit: tests typically have a space between "if" and "("

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:51
> +                    if(deviceInfo.deviceId === deviceId && deviceInfo.kind === deviceKind) {

Ditto.

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:89
> +                },e => {

Nit: missing a space between "," and "e"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180611/6dbcf971/attachment.html>