[Webkit-unassigned] [Bug 174816] [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 03:37:41 PDT 2018


--- Comment #60 from Ms2ger <Ms2ger at igalia.com> ---
Comment on attachment 332474
  --> https://bugs.webkit.org/attachment.cgi?id=332474

View in context: https://bugs.webkit.org/attachment.cgi?id=332474&action=review

> Source/WebCore/platform/URLParser.cpp:3073
> +        if (previousCodePoint != INT32_MAX && URLParser::isLookalikeCharacter(c, previousCodePoint))

Adding the `previousCodePoint != INT32_MAX` seems likely to change the behaviour here.

> Source/WebCore/platform/URLParser.cpp:3290
> +    if (allCharactersInIDNScriptWhiteList(outputBuffer, outputLength, IDNScriptWhiteList) && allCharactersAllowedByTLDRules(outputBuffer, outputLength))

In inverting the condition, you changed !(!A && !B) to (A && B) where it should have been (A || B); this is (at least one of the) bug(s) that caused the test failures.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180611/3584e710/attachment.html>

More information about the webkit-unassigned mailing list