[Webkit-unassigned] [Bug 186379] Run display links in the UI process when ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) is true.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186379

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342110|review?                     |review+
              Flags|                            |

--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342110
  --> https://bugs.webkit.org/attachment.cgi?id=342110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342110&action=review

Looks good.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:29
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

I wonder if we need the PLATFORM(MAC) here, since this is a Mac-specific file I think.

> Source/WebKit/UIProcess/mac/DisplayLink.h:28
> +#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Ditto.

> Source/WebKit/WebProcess/WebPage/mac/DrawingAreaMac.cpp:41
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) && PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)

Again, I wonder if PLATFORM(MAC) is necessary in this Mac-specific file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180608/62846f42/attachment.html>